Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_sesv2_email_identity_mail_from_attributes: new resource #27672

Merged
merged 13 commits into from
Nov 11, 2022
Merged

r/aws_sesv2_email_identity_mail_from_attributes: new resource #27672

merged 13 commits into from
Nov 11, 2022

Conversation

kamilturek
Copy link
Collaborator

Description

This PR introduces the aws_sesv2_email_identity_mail_from_attributes resource.

Relations

Relates #26796.

References

https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_PutEmailIdentityMailFromAttributes.html

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccSESV2EmailIdentityMailFromAttributes_' PKG=sesv2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 2  -run=TestAccSESV2EmailIdentityMailFromAttributes_ -timeout 180m
=== RUN   TestAccSESV2EmailIdentityMailFromAttributes_basic
=== PAUSE TestAccSESV2EmailIdentityMailFromAttributes_basic
=== RUN   TestAccSESV2EmailIdentityMailFromAttributes_disappears
=== PAUSE TestAccSESV2EmailIdentityMailFromAttributes_disappears
=== RUN   TestAccSESV2EmailIdentityMailFromAttributes_behaviorOnMXFailure
=== PAUSE TestAccSESV2EmailIdentityMailFromAttributes_behaviorOnMXFailure
=== RUN   TestAccSESV2EmailIdentityMailFromAttributes_mailFromDomain
=== PAUSE TestAccSESV2EmailIdentityMailFromAttributes_mailFromDomain
=== CONT  TestAccSESV2EmailIdentityMailFromAttributes_basic
=== CONT  TestAccSESV2EmailIdentityMailFromAttributes_behaviorOnMXFailure
--- PASS: TestAccSESV2EmailIdentityMailFromAttributes_basic (29.15s)
=== CONT  TestAccSESV2EmailIdentityMailFromAttributes_mailFromDomain
--- PASS: TestAccSESV2EmailIdentityMailFromAttributes_behaviorOnMXFailure (47.77s)
=== CONT  TestAccSESV2EmailIdentityMailFromAttributes_disappears
--- PASS: TestAccSESV2EmailIdentityMailFromAttributes_disappears (19.39s)
--- PASS: TestAccSESV2EmailIdentityMailFromAttributes_mailFromDomain (44.30s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      75.237s

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/sesv2 Issues and PRs that pertain to the sesv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 6, 2022
@kamilturek kamilturek marked this pull request as ready for review November 6, 2022 23:47
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 7, 2022
@jar-b jar-b self-assigned this Nov 11, 2022
kamilturek
kamilturek commented Nov 11, 2022
View reviewed changes
internal/service/sesv2/email_identity_mail_from_attributes.go
Type: schema.TypeString,
Optional: true,
Default: string(types.BehaviorOnMxFailureUseDefaultValue),
ValidateDiagFunc: enum.Validate[types.BehaviorOnMxFailure](),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is really handy! Thanks, TIL! 🙌

jar-b
jar-b approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc PKG=sesv2 TESTS=TestAccSESV2EmailIdentityMailFromAttributes
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2EmailIdentityMailFromAttributes'  -timeout 180m
=== RUN   TestAccSESV2EmailIdentityMailFromAttributes_basic
=== PAUSE TestAccSESV2EmailIdentityMailFromAttributes_basic
=== RUN   TestAccSESV2EmailIdentityMailFromAttributes_disappears
=== PAUSE TestAccSESV2EmailIdentityMailFromAttributes_disappears
=== RUN   TestAccSESV2EmailIdentityMailFromAttributes_disappearsEmailIdentity
=== PAUSE TestAccSESV2EmailIdentityMailFromAttributes_disappearsEmailIdentity
=== RUN   TestAccSESV2EmailIdentityMailFromAttributes_behaviorOnMXFailure
=== PAUSE TestAccSESV2EmailIdentityMailFromAttributes_behaviorOnMXFailure
=== RUN   TestAccSESV2EmailIdentityMailFromAttributes_mailFromDomain
=== PAUSE TestAccSESV2EmailIdentityMailFromAttributes_mailFromDomain
=== CONT  TestAccSESV2EmailIdentityMailFromAttributes_basic
=== CONT  TestAccSESV2EmailIdentityMailFromAttributes_behaviorOnMXFailure
=== CONT  TestAccSESV2EmailIdentityMailFromAttributes_disappearsEmailIdentity
=== CONT  TestAccSESV2EmailIdentityMailFromAttributes_mailFromDomain
=== CONT  TestAccSESV2EmailIdentityMailFromAttributes_disappears
--- PASS: TestAccSESV2EmailIdentityMailFromAttributes_disappearsEmailIdentity (14.17s)
--- PASS: TestAccSESV2EmailIdentityMailFromAttributes_basic (19.28s)
--- PASS: TestAccSESV2EmailIdentityMailFromAttributes_disappears (19.63s)
--- PASS: TestAccSESV2EmailIdentityMailFromAttributes_mailFromDomain (29.73s)
--- PASS: TestAccSESV2EmailIdentityMailFromAttributes_behaviorOnMXFailure (30.46s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      33.155s

@jar-b jar-b merged commit bc0c9f7 into hashicorp:main Nov 11, 2022
@github-actions github-actions bot added this to the v4.40.0 milestone Nov 11, 2022
@jar-b
Copy link
Member

jar-b commented Nov 11, 2022 •
edited
Loading

Thanks for your contribution @kamilturek!

This was in great shape, just made a couple small adjustments:

  • replaced name attribute references with email_identity
  • split _disappears tests into one where mail from attributes are removed and another where email identity is deleted
  • made use of the enum.Validate function

@github-actions
Copy link

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees

@jar-b jar-b

Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/sesv2 Issues and PRs that pertain to the sesv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.40.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kamilturek @jar-b @justinretzolk